Fix Aqara high precision motion sensor not detecting motion #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov upload fail is unrelated. This PR also doesn't affect coverage. |
lgraf
pushed a commit
to lgraf/zha-device-handlers
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Even though Aqara high precision motion sensors send false occupancy reports every hour (home-assistant/core#114129), at least some firmware versions actually use the ZCL cluster for sending occupancy reports.
This PR changes the agl04 quirk to parse ZCL occupancy reports again. This fixes the issue of some of these devices not detecting motion at all.
Additional information
This partly reverts #2779 (for the agl04 / high precision sensor). The T1 sensor fix is correct.
Addresses home-assistant/core#115027
Checklist
pre-commitchecks pass / the code has been formatted using Black