-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Schneider quirks using spec docs #3111
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3111 +/- ##
==========================================
+ Coverage 88.10% 88.14% +0.03%
==========================================
Files 299 299
Lines 9358 9386 +28
==========================================
+ Hits 8245 8273 +28
Misses 1113 1113 ☔ View full report in Codecov by Sentry. |
13784c6
to
bf45816
Compare
bf45816
to
334553f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks pretty good, thanks!
@dflemstr thank you for you work on this. If I understand it correctly, the signature/name of my dimmer is listed here: |
@uvNikita You are right that extra changes are needed for your device to be supported. Another |
I added support for your device like this in zigbee2mqtt to give you an idea: Koenkk/zigbee-herdsman-converters#7454 I'm not sure if I will have time to make the equivalent change here though since adding devices in |
Just wanted to add that ELKO is selling this devices under its name after it was acquired by schneider. I hope we can have this UNIDIM device included also |
Proposed change
This is a start of using the leaked Schneider Electric specification docs posted by @uvNikita in #1705, linked here again for convenience: https://drive.google.com/file/d/1rM9iVhAB-AlWwWhvpEtcReSpEATi7aVH/view
So far I have looked at the light related specs and updated the attributes with the information for the specs docs. More improvements could probably be made by incorporating info from the other device types too, but I only have light-related devices in my home (dimmers, switches, etc) so I can't test any other changes right now.
The comments have a number of grammar issues etc, but I copied them verbatim from the spec, so if there are any ambiguous statements, your guess is as good as mine!
Additional information
This PR renames some python variables/constant names to match the spec. I doubt that anything is using these in code already; if so, this could be a breaking change. I suppose @cspurk is the only person I know of that might be using this?
Checklist
pre-commit
checks pass / the code has been formatted using Black