Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya Giex GX02 water valve support #3124

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

DavHau
Copy link
Contributor

@DavHau DavHau commented Apr 24, 2024

Proposed change

This device: https://de.aliexpress.com/item/1005006547328147.html
Patch is confirmed:

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Apr 25, 2024
@TheJulianJES TheJulianJES changed the title Add support for Giex GX02 Water Valve Add Tuya Giex GX02 water valve support Apr 25, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.14%. Comparing base (04ba4a7) to head (88cf679).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3124   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files         299      299           
  Lines        9389     9389           
=======================================
  Hits         8276     8276           
  Misses       1113     1113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES merged commit bfbfb48 into zigpy:dev Apr 25, 2024
6 checks passed
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
@Pokeypoet
Copy link

Hello, sorry it this is a stupid question but when I can expect this change to be live in homeassistant?
Alternatively what is the work around to make it work now?

I have a couple or these valves and would like to make use of them

@DavHau DavHau deleted the patch-1 branch May 19, 2024 10:43
@pablopezg
Copy link

As far as I checked, only battery and ON/OFF functionality is implemented. Do you know when the rest of features will be implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants