-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LevelControl
cluster for IKEA plugs
#3174
Remove LevelControl
cluster for IKEA plugs
#3174
Conversation
This removes the `LevelControl` cluster for IKEA TRADFRI and TRETAKT smart plugs, so the config options aren't shown in ZHA.
This is no longer needed, as the v2 quirk also matches all of these devices.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3174 +/- ##
==========================================
- Coverage 88.19% 88.18% -0.02%
==========================================
Files 300 300
Lines 9400 9392 -8
==========================================
- Hits 8290 8282 -8
Misses 1110 1110 ☔ View full report in Codecov by Sentry. |
Codecov project coverage decrease is expected, as the old quirk had quite a few lines and is now fully removed with this. |
Not possible testing then ZHA is trying using both old (HA 2024.5.X) and new local quirks and is not loading:
But i like the design of the quirk !!!! |
Works properly @TheJulianJES ! :D Can you rename "zigpy.quirks.v2.CustomDeviceV2" (the CustomDeviceV2 part) to "Ikea_Plugs_v2" or similar? |
Thanks for testing! |
Thank you very much for all you do for ZHA, glad to help. |
Proposed change
Adds a v2 quirk for IKEA plugs that removes the
LevelControl
cluster for IKEA TRADFRI and TRETAKT smart plugs, so the config options aren't shown in ZHA.The old Tradfri plug quirk is also no longer needed and thus removed, as the v2 quirk also matches all of those deviecs.
Additional information
Supersedes #3145
This is still untested, but should work fine. Feedback is welcome!
Checklist
pre-commit
checks pass / the code has been formatted using Black