Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UseeLink/Tuya cover support _TZ3000_ltiqubue #3186

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

Maddimax
Copy link
Contributor

@Maddimax Maddimax commented Jun 3, 2024

Proposed change

Add support for Tuya style Cover from "UseeLink"

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black

@Maddimax Maddimax changed the title Useelink Support for TS130F from Useelink Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.18%. Comparing base (c6ed94a) to head (17845c6).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3186      +/-   ##
==========================================
+ Coverage   88.17%   88.18%   +0.01%     
==========================================
  Files         300      301       +1     
  Lines        9386     9412      +26     
==========================================
+ Hits         8276     8300      +24     
- Misses       1110     1112       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Maddimax Maddimax changed the title Support for TS130F from Useelink Support for _TZ3000_ltiqubue Jun 6, 2024
@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Jun 21, 2024
@TheJulianJES TheJulianJES changed the title Support for _TZ3000_ltiqubue Add UseeLink/Tuya cover support _TZ3000_ltiqubue Jun 26, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've also replaced the OnOff cluster with a Tuya manufacturer specific one, like the other covers use. It just makes one extra attribute available on the cluster.

@TheJulianJES TheJulianJES merged commit 8317dc6 into zigpy:dev Jun 26, 2024
6 checks passed
xbezdick pushed a commit to xbezdick/zha-device-handlers that referenced this pull request Jul 6, 2024
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants