Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Avatto/Tuya 1/2-ch dimmer support #3190

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

NH-Networks
Copy link
Contributor

@NH-Networks NH-Networks commented Jun 6, 2024

#Avatto 1/2-ch dimmer support #3141

TS0601_TZE204_o9gyszw2
TS0601_TZE204_5cuocqty

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

…_5cuocqty

Avatto 1/2-ch dimmer support 

TS0601_TZE204_o9gyszw2
TS0601_TZE204_5cuocqty
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.17%. Comparing base (c6ed94a) to head (3fea2ef).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3190   +/-   ##
=======================================
  Coverage   88.17%   88.17%           
=======================================
  Files         300      300           
  Lines        9386     9386           
=======================================
  Hits         8276     8276           
  Misses       1110     1110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Z2M has these listed as a separate device. I'll need to have a closer look at that.
But if these work fine for you, this might be good to go.

zhaquirks/tuya/ts0601_dimmer.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts0601_dimmer.py Outdated Show resolved Hide resolved
@NH-Networks
Copy link
Contributor Author

Z2M has these listed as a separate device. I'll need to have a closer look at that. But if these work fine for you, this might be good to go.

Working perfectly, it is same device but just 1ch and 2ch.. have them both and work fine this way

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Jun 21, 2024
@TheJulianJES TheJulianJES changed the title Add support for Avatto 1/2-ch dimmer. TS0601 _TZE204_o9gyszw2/_TZE204… Add Avatto/Tuya 1/2-ch dimmer support Jun 26, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES merged commit 6907545 into zigpy:dev Jun 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants