Add quirks for new Sinopé Load Controller #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3195 +/- ##
=======================================
Coverage 88.17% 88.18%
=======================================
Files 300 300
Lines 9386 9393 +7
=======================================
+ Hits 8276 8283 +7
Misses 1110 1110 ☔ View full report in Codecov by Sentry. |
claudegel
changed the title
javicalle
reviewed
Jun 9, 2024
zhaquirks/sinope/switch.py
Outdated
| @@ -326,6 +327,67 @@ class SinopeTechnologiesLoadController(CustomDevice): | |||
| } | |||
|
|
|||
|
|
|||
| class SinopeTechnologiesNewLoadController(CustomDevice): | |||
There was a problem hiding this comment.
IMHO bad naming.
I would prefer SinopeTechnologiesLoadController_var02 or similar.
Otherwise you can get sometime a SinopeTechnologiesNewNewLoadController 😉
There was a problem hiding this comment.
better like this SinopeTechnologiesLoadController_V2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Additional information
New load controller have cluster 0x0002 that is missing in old load controller
Checklist
pre-commitchecks pass / the code has been formatted using Black