Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya Giex valve _TZE200_7ytb3h8u #3281

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Conversation

MindFreeze
Copy link
Contributor

@MindFreeze MindFreeze commented Aug 3, 2024

Proposed change

Adding this valve's manufacturer code to the relevant quirk
https://www.aliexpress.com/item/1005006547328147.html
Watering Timer Smart Sprinkler Drip Irrigation System Built-in Water Flow Recorder Controller TUYA

Without this it pairs with no entities

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.18%. Comparing base (e3c115e) to head (369b086).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3281   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files         301      301           
  Lines        9412     9412           
=======================================
  Hits         8300     8300           
  Misses       1112     1112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES changed the title add _TZE200_7ytb3h8u to ts0601_valve.py Add Tuya Giex valve _TZE200_7ytb3h8u Aug 3, 2024
@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Aug 3, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES merged commit 99cfdc4 into zigpy:dev Aug 3, 2024
6 checks passed
@MayeulC
Copy link

MayeulC commented Aug 3, 2024

You beat me to this PR :)
Here are a few things I just wrote about this device: https://community.home-assistant.io/t/giex-smart-water-valve-with-zha/745628/9

Is there any documentation on adding a "Configuration" section to the device UI in HA, like some Tuya plugs seem to have? I could not locate the associated code.

Going by the source linked in the code, it may be worth adding the following IDs as well:

  • _TZE204_a7sghmms
  • _TZE284_7ytb3h8u
    Though I do not own them, so I cannot confirm that they are compatible.

@TheJulianJES
Copy link
Collaborator

Config entities can be added via quirks v2 now. There's a pending draft PR for docs.
Previously, they had to be added in the ZHA integration in Home Assistant Core. Now, it has is a separate library.

@MindFreeze MindFreeze deleted the giex-valve branch August 4, 2024 10:43
danielp370 pushed a commit to danielp370/zha-device-handlers that referenced this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants