-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Xiaomi attribute report parsing #883
Merged
dmulcahey
merged 3 commits into
zigpy:dev
from
puddly:puddly/fix-xiaomi-attribute-parsing
Aug 26, 2021
Merged
Improve Xiaomi attribute report parsing #883
dmulcahey
merged 3 commits into
zigpy:dev
from
puddly:puddly/fix-xiaomi-attribute-parsing
Aug 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1167290720
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## dev #883 +/- ##
==========================================
+ Coverage 82.50% 82.85% +0.35%
==========================================
Files 185 194 +9
Lines 4589 4877 +288
==========================================
+ Hits 3786 4041 +255
- Misses 803 836 +33
Continue to review full report at Codecov.
|
puddly
force-pushed
the
puddly/fix-xiaomi-attribute-parsing
branch
from
July 13, 2021 17:26
ab81a61
to
0d641e6
Compare
@puddly hows this one goin? |
Lemme look over it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xiaomi attribute reports apparently can contain off-by-one length errors in the other direction too (#881):
They usually look like:
Or are the correct length.
In all of these cases the attribute report needs to be postprocessed, since the data type is incorrect and this leads to binary data being written to log files (home-assistant/core#24668):
I've changed the data type from "Character String" (0x42) to "Octet String" (0x41) to fix this.