[Device Support] Neo temperature humidity and illumance sensor quirk #926

marciogranzotto · 2021-06-16T17:53:59Z

Implements temperature and humidity for the Neo TS0201 _TZ3000_qaaysllp sensor: #862

Thanks to @blakadder, @Vebryn, and all others involved in the issue discussion!

walnuss0815 · 2021-06-16T21:34:51Z

first: Thanks for your great work! Unfortunately it does not work form me. :( I have added the file to my custom quirk directory and already tried resetting and reconnecting the device. The states of temperature and humidity are unknown and I am getting the following errors:

2021-06-16 23:17:29 WARNING (MainThread) [zigpy.zcl] Unknown cluster 57346
2021-06-16 23:17:29 WARNING (MainThread) [zigpy.zcl] Unknown cluster 57346
.
.
.
2021-06-16 23:18:30 WARNING (MainThread) [zigpy.device] [0x0000] Requesting Node Descriptor failed
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/zigpy/device.py", line 102, in get_node_descriptor
status, _, node_desc = await self.zdo.Node_Desc_req(
File "/usr/local/lib/python3.8/site-packages/zigpy/util.py", line 110, in retry
r = await func()
File "/usr/local/lib/python3.8/site-packages/zigpy/device.py", line 225, in request
result = await asyncio.wait_for(req.result, timeout)
File "/usr/local/lib/python3.8/asyncio/tasks.py", line 501, in wait_for
raise exceptions.TimeoutError()
asyncio.exceptions.TimeoutError
.
.
.
2021-06-16 23:18:46 WARNING (MainThread) [homeassistant.components.zha.core.channels.base] [0xe6c8:1:0x0400]: 'async_configure' stage failed: 'uint8_t' object is not subscriptable
2021-06-16 23:18:46 WARNING (MainThread) [homeassistant.components.zha.core.channels.base] [0xe6c8:1:0x0001]: 'async_configure' stage failed: 'uint8_t' object is not subscriptable

marciogranzotto · 2021-06-17T12:44:11Z

@walnuss0815 I don't think your problem is releated with this change, since it looks like a communication issue. Can you test if you still have the problem without this code change?

I have two of those sensors and I was able to add them flawlessly

walnuss0815 · 2021-06-17T15:45:24Z

I've removed the code change and two of the log messages were gone. After I added the code change again the log messages were back. So it apears that the following log entries are caused by the the code change:

2021-06-17 17:38:47 WARNING (MainThread) [homeassistant.components.zha.core.channels.base] [0x0DAD:1:0x0400]: 'async_configure' stage failed: 'uint8_t' object is not subscriptable
2021-06-17 17:38:47 WARNING (MainThread) [homeassistant.components.zha.core.channels.base] [0x0DAD:1:0x0001]: 'async_configure' stage failed: 'uint8_t' object is not subscriptable
.
.
.
Unknown cluster 57346

marciogranzotto · 2021-06-18T14:34:05Z

@walnuss0815 but without these changes can you add the device and see its illuminance and battery info?
Also, I just committed a change removing the 0xE002 cluster in the replacement, can you check if that makes any difference?

@blakadder, @Vebryn - do you guys experience the same problem? or it works for you?

walnuss0815 · 2021-06-18T16:09:44Z

@marciogranzotto right, before I added the file there only were the battery info and the illuminance.

The latest commit did not fix the issue. Temperature and humidity are still unknown.

marciogranzotto · 2021-06-27T00:47:10Z

Just pushed a new commit that may solve the problem.

However, the tests will fail since the Neo cluster (0xe002) is not on the default cluster list and neither between 0xfc00 and 0xffff

Any ideas on how to proceed?

zhaquirks/tuya/neo_TS0201.py

Adminiuga · 2021-06-27T03:25:41Z

zhaquirks/tuya/neo_TS0201.py

+    def __init__(self, device, endpoint_id):
+        super().__init__(device, endpoint_id)
+        self.info("Forcing discovery information for Neo custom endpoint")
+
+        self.profile_id = zha.PROFILE_ID
+        self.device_type = DeviceType.TEMPERATURE_SENSOR
+        self.device_type = zigpy.profiles.zha.DeviceType(self.device_type)
+
+        self.add_input_cluster(
+            TemperatureMeasurement.cluster_id,
+            TemperatureMeasurement(endpoint=self, is_server=True),
+        )
+        self.add_input_cluster(
+            RelativeHumidity.cluster_id,
+            RelativeHumidity(endpoint=self, is_server=True),
+        )
+        self.status = zigpy.endpoint.Status.ZDO_INIT


No need for this. The reason why the replacement endpoint id 2 failed, is because you did not have PROFILE_ID defined in the replacement. I've checked and you can add a new endpoint via replacement

zhaquirks/tuya/neo_TS0201.py

codecov-commenter · 2021-06-30T23:49:52Z

Codecov Report

Merging #926 (2c2922c) into dev (3875b3d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #926      +/-   ##
==========================================
+ Coverage   82.58%   82.65%   +0.06%     
==========================================
  Files         190      191       +1     
  Lines        4807     4825      +18     
==========================================
+ Hits         3970     3988      +18     
  Misses        837      837

Impacted Files	Coverage Δ
zhaquirks/tuya/neo_TS0201.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3875b3d...2c2922c. Read the comment docs.

coveralls · 2021-06-30T23:50:26Z

Pull Request Test Coverage Report for Build 1156504411

18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 82.653%

Totals
Change from base Build 1156500807:	0.06%
Covered Lines:	3988
Relevant Lines:	4825

💛 - Coveralls

Adminiuga

Flake8 changes

zhaquirks/tuya/neo_TS0201.py

Co-authored-by: Alexei Chetroi <lexoid@gmail.com>

dmulcahey · 2021-08-25T11:12:29Z

@Adminiuga good to go?

Adminiuga

Lgtm

Neo temperature humidity and illumance sensor quirk

2bc43dc

Fix tests not passing for Neo sensor

87760e5

Fix 0xE002 cluster for Neo sensor

30dd197

Adminiuga reviewed Jun 27, 2021

View reviewed changes

zhaquirks/tuya/neo_TS0201.py Outdated Show resolved Hide resolved

Adminiuga reviewed Jun 27, 2021

View reviewed changes

zhaquirks/tuya/neo_TS0201.py Outdated Show resolved Hide resolved

Adminiuga reviewed Jun 27, 2021

View reviewed changes

zhaquirks/tuya/neo_TS0201.py Show resolved Hide resolved

Simplify Neo sensor quirk

6e100f5

Adminiuga reviewed Jul 5, 2021

View reviewed changes

zhaquirks/tuya/neo_TS0201.py Outdated Show resolved Hide resolved

zhaquirks/tuya/neo_TS0201.py Outdated Show resolved Hide resolved

marciogranzotto and others added 5 commits July 5, 2021 10:29

Update zhaquirks/tuya/neo_TS0201.py

f2a37f3

Co-authored-by: Alexei Chetroi <lexoid@gmail.com>

Update zhaquirks/tuya/neo_TS0201.py

1f0cca6

Co-authored-by: Alexei Chetroi <lexoid@gmail.com>

Merge branch 'zigpy:dev' into dev

846e9c5

Merge branch 'zigpy:dev' into dev

158315a

Merge remote-tracking branch 'upstream/dev' into dev

2c2922c

Adminiuga approved these changes Aug 25, 2021

View reviewed changes

Adminiuga merged commit 14a78b9 into zigpy:dev Aug 25, 2021

MattWestb mentioned this pull request Sep 5, 2021

[Device Support Request] _TZE200_wunufsil TS0601 (Tuya 2 gang touch switch) #972

Closed

almico mentioned this pull request Sep 20, 2021

[Device Support Request] TS0222 by _TYZB01_kvwjujy9 (E-Ink Brightness Thermometer) #961

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Device Support] Neo temperature humidity and illumance sensor quirk #926

[Device Support] Neo temperature humidity and illumance sensor quirk #926

marciogranzotto commented Jun 16, 2021

walnuss0815 commented Jun 16, 2021

marciogranzotto commented Jun 17, 2021 •

edited

Loading

walnuss0815 commented Jun 17, 2021 •

edited

Loading

marciogranzotto commented Jun 18, 2021 •

edited

Loading

walnuss0815 commented Jun 18, 2021

marciogranzotto commented Jun 27, 2021 •

edited

Loading

Adminiuga Jun 27, 2021

codecov-commenter commented Jun 30, 2021 •

edited

Loading

coveralls commented Jun 30, 2021 •

edited

Loading

Adminiuga left a comment

dmulcahey commented Aug 25, 2021

Adminiuga left a comment

[Device Support] Neo temperature humidity and illumance sensor quirk #926

[Device Support] Neo temperature humidity and illumance sensor quirk #926

Conversation

marciogranzotto commented Jun 16, 2021

walnuss0815 commented Jun 16, 2021

marciogranzotto commented Jun 17, 2021 • edited Loading

walnuss0815 commented Jun 17, 2021 • edited Loading

marciogranzotto commented Jun 18, 2021 • edited Loading

walnuss0815 commented Jun 18, 2021

marciogranzotto commented Jun 27, 2021 • edited Loading

Adminiuga Jun 27, 2021

Choose a reason for hiding this comment

codecov-commenter commented Jun 30, 2021 • edited Loading

Codecov Report

coveralls commented Jun 30, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1156504411

💛 - Coveralls

Adminiuga left a comment

Choose a reason for hiding this comment

dmulcahey commented Aug 25, 2021

Adminiuga left a comment

Choose a reason for hiding this comment

marciogranzotto commented Jun 17, 2021 •

edited

Loading

walnuss0815 commented Jun 17, 2021 •

edited

Loading

marciogranzotto commented Jun 18, 2021 •

edited

Loading

marciogranzotto commented Jun 27, 2021 •

edited

Loading

codecov-commenter commented Jun 30, 2021 •

edited

Loading

coveralls commented Jun 30, 2021 •

edited

Loading