Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BTicino L441C/N4411C/NT4411C. #951

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Add support for BTicino L441C/N4411C/NT4411C. #951

merged 1 commit into from
Aug 25, 2021

Conversation

MidnessX
Copy link
Contributor

@MidnessX MidnessX commented Jul 9, 2021

Hi,
I've added support for the manufacturer specific cluster found in BTicino (a Legrand subsidiary) dimmer switch with neutral (models L441C/N4411C/NT4411C).
Most of the work was already done for another Legrand dimmer, so I only had to subclass that implementation and change the signature.

@dmulcahey dmulcahey closed this Aug 25, 2021
@dmulcahey dmulcahey reopened this Aug 25, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1166587054

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 89 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 82.691%

Files with Coverage Reduction New Missed Lines %
zhaquirks/tuya/ts130f.py 4 77.5%
zhaquirks/tuya/init.py 85 72.43%
Totals Coverage Status
Change from base Build 1006209655: 0.09%
Covered Lines: 4013
Relevant Lines: 4853

💛 - Coveralls

@dmulcahey dmulcahey merged commit cf1c606 into zigpy:dev Aug 25, 2021
@Valcob
Copy link
Contributor

Valcob commented Oct 3, 2022

hey guys could you please confirm that you are able to switch the dimmer into dimming mode as for me the manufacturer specific cluster attributes are empty
image
and I have no way to configure device_mode, led_in_dark, led_if_on
image

@MidnessX
Copy link
Contributor Author

MidnessX commented Oct 4, 2022

@Valcob
Hi, yes, I can enable or disable the dimming functionality and alter the LED behavior.
However, cluster 0xFC01 is correctly listed as LegrandCluster rather than ManufacturerSpecificCluster in my Home Assistant front-end.

image

@Valcob
Copy link
Contributor

Valcob commented Oct 4, 2022

What's the version you are using? you can download the diagnostic info from three dots menu of the integration
image
and then check the integration manifest
image

@MidnessX
Copy link
Contributor Author

MidnessX commented Oct 4, 2022

I'm running the same version of zigpy as you.

"integration_manifest": {
    "domain": "zha",
    "name": "Zigbee Home Automation",
    "config_flow": true,
    "documentation": "https://www.home-assistant.io/integrations/zha",
    "requirements": [
      "bellows==0.33.1",
      "pyserial==3.5",
      "pyserial-asyncio==0.6",
      "zha-quirks==0.0.79",
      "zigpy-deconz==0.18.1",
      "zigpy==0.50.3",
      "zigpy-xbee==0.15.0",
      "zigpy-zigate==0.9.2",
      "zigpy-znp==0.8.2"
    ],
...

You should remove the dimmer from your network and join it again, while simultaneously capturing debug logs for zha and zha-quirks.
I suspect your dimmer firmware version is exposing slightly different clusters from what is currently supported in zha-quirks.

@Valcob
Copy link
Contributor

Valcob commented Oct 4, 2022

interesting I have this:
Read model ' Dimmer switch with neutral' and manufacturer ' Legrand' from <Endpoint id=1 in=[basic:0x0000, identify:0x0003, groups:0x0004, level:0x0008, on_off:0x0006, scenes:0x0005, binary_input:0x000F, manufacturer_specific:0xFC01] out=[basic:0x0000, manufacturer_specific:0xFC01, scenes:0x0005, ota:0x0019] status=<Status.ZDO_INIT: 1>>
looks like some output cluster is wrong
DEBUG (MainThread) [zigpy.quirks.registry] Checking quirks for Legrand Dimmer switch with neutral (
[zigpy.quirks.registry] Considering <class 'zhaquirks.legrand.dimmer.DimmerWithNeutral'> [zigpy.quirks.registry] Fail because output cluster mismatch on at least one endpoint

@MidnessX
Copy link
Contributor Author

MidnessX commented Oct 4, 2022

I can see your dimmer has an additional scenes output cluster that is missing from the currently supported device in zhaquirks/legrand/dimmer.py.

@Valcob
Copy link
Contributor

Valcob commented Oct 4, 2022

yeah I'm already creating a PR just a moment :)

@MidnessX
Copy link
Contributor Author

MidnessX commented Oct 4, 2022

You can easily test new quirks by enabling this setting in the Home Assistant config and putting modules in the specified directory.
Let me know if I can be of further help!

@Valcob
Copy link
Contributor

Valcob commented Oct 4, 2022

tested locally it works, THANKS!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants