Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ts0041.py for using MODEL: "TS0041", instead of MODELS_INFO, #957

Merged
merged 5 commits into from
Jul 13, 2021
Merged

Update ts0041.py for using MODEL: "TS0041", instead of MODELS_INFO, #957

merged 5 commits into from
Jul 13, 2021

Conversation

MattWestb
Copy link
Contributor

Using MODEL: "TS0041", for both types (time cluster as in or out).

Using MODEL: "TS0041", for both types (time cluster as in or out).
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2021

Codecov Report

Merging #957 (cdf38b4) into dev (302cf4c) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #957      +/-   ##
==========================================
- Coverage   82.60%   82.55%   -0.06%     
==========================================
  Files         191      189       -2     
  Lines        4812     4798      -14     
==========================================
- Hits         3975     3961      -14     
  Misses        837      837              
Impacted Files Coverage Δ
zhaquirks/tuya/ts0041.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302cf4c...cdf38b4. Read the comment docs.

Deleting ts0041_zemismart.py then its being covered by ts0041.py
@coveralls
Copy link

coveralls commented Jul 11, 2021

Pull Request Test Coverage Report for Build 1020496065

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 82.555%

Totals Coverage Status
Change from base Build 1020113186: -0.05%
Covered Lines: 3961
Relevant Lines: 4798

💛 - Coveralls

Deleting ts0041_moes.py then its covered by ts0041.py
Spelling ;-(
Deleting MODELS_INFO then its not used.
@MattWestb
Copy link
Contributor Author

MattWestb commented Jul 11, 2021

This closing #956 with ("_TZ3000_iklyvnq3" , "TS0041"), as new device.

Also old ID is not longer used but was working OK but for the history:
("_TZ3000_pzui3skt", "TS0041"),
("_TZ3000_xkwalgne", "TS0041"),
("_TZ3000_peszejy7", "TS0041"),
("_TZ3000_iklyvnq3" , "TS0041"),
("_TZ3000_tk3s5tyg", "TS0041"),
("_TZ3000_q68478x7", "TS0041"),
("_TZ3000_4upl1fcj", "TS0041"),
("_TZ3400_keyjqthh", "TS0041"),
("_TZ3000_4upl1fcj", "TS0041"),

@MattWestb MattWestb marked this pull request as ready for review July 11, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants