-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating TS0042 using tuya general device name. #958
Conversation
Changing name to general tuya device.
Using MODEL: "TS0044", and general tuya naming
Renaming the TS0042, TS0043 and TS0044 naming using general tuya name and using MODEL: "TS0044", for the TS0044. Problems is then deleting the device IDs: I like the change nit fixing the test is out of my knowledge ;-(( Can some dev helping fixing the test or i deleting the PR if its not interesting for the project. |
The problem is:
Shall i putting the new names for all with the manufacture name ? |
Is this the right way fixing the test ???
|
Fixed class names after renaming them.
One more try
Pull Request Test Coverage Report for Build 1025565093
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## dev #958 +/- ##
==========================================
- Coverage 82.60% 82.55% -0.06%
==========================================
Files 191 189 -2
Lines 4812 4798 -14
==========================================
- Hits 3975 3961 -14
Misses 837 837
Continue to review full report at Codecov.
|
Added test for 41 and 44
Was trying getting the test Coverage up be adding the 41 and 44 variant but i dont knowing if its helping. More feedback is needed if I shall doing more changes or if its OK then merger. Mvh MW |
Fixes #935 |
Fixes #952 that is not committed (one more TS0044). |
Changing name to general tuya device.
Fixes #935, fixes #952