Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some more tuya TS0601 touch switches #976

Merged
merged 3 commits into from
Jul 25, 2021
Merged

Adding some more tuya TS0601 touch switches #976

merged 3 commits into from
Jul 25, 2021

Conversation

MattWestb
Copy link
Contributor

Adding:

         MODELS_INFO: [
            ("_TZE200_oisqyl4o", "TS0601"),
            ("_TZE200_wunufsil", "TS0601"),
            ("_TZE200_vhy3iakz", "TS0601"),
            ("_TZ3000_uim07oem", "TS0601"),
            ("_TZE200_tz32mtza", "TS0601"),

The quirk is made for only one gang switches and some of the new is multiple one.
The first gang is working OK but the 2 and higher is not working :-((

For the moment is better then not working at all but its needs little patching for working OK with all gangs.
Some users is trying getting the code fixed but i think its OK for first shut for getting the users getting little use of there devices.

Feel free reacting this PR if not liking the approach or helping fixing the code for supporting multiple gang devices.

Adding:
```
         MODELS_INFO: [
            ("_TZE200_oisqyl4o", "TS0601"),
            ("_TZE200_wunufsil", "TS0601"),
            ("_TZE200_vhy3iakz", "TS0601"),
            ("_TZ3000_uim07oem", "TS0601"),
            ("_TZE200_tz32mtza", "TS0601"),
```
The quirk is made  for only one gang switches and some of the new is multiple one.
The first gang is working OK but the 2 and higher is not working :-((

For the moment is better then not working at all but its needs little patching for working OK with all gangs.
Some users is trying getting the code fixed but i think its OK for first shut for getting the users getting little use of there devices.

Feel free reacting this PR if not liking the approach or helping fixing the code for supporting multiple gang devices.
@MattWestb
Copy link
Contributor Author

Closing issue #972 and #966

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2021

Codecov Report

Merging #976 (2859255) into dev (b7e6173) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #976   +/-   ##
=======================================
  Coverage   82.55%   82.55%           
=======================================
  Files         189      189           
  Lines        4798     4798           
=======================================
  Hits         3961     3961           
  Misses        837      837           
Impacted Files Coverage Δ
zhaquirks/tuya/ts0601.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e6173...2859255. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 25, 2021

Pull Request Test Coverage Report for Build 1064494162

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.555%

Totals Coverage Status
Change from base Build 1024783287: 0.0%
Covered Lines: 3961
Relevant Lines: 4798

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants