Fix OSRAM Switch Mini big arrow long press #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces COMMAND_STEP_ON_OFF with COMMAND_MOVE_ON_OFF for the big arrow key, as stated in https://gist.github.com/majkrzak/333417ea2d7e59f149c51e8016d10962
Pull Request Test Coverage Report for Build 1071110049
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This quirk was originally created based on the event trace in https://gist.github.com/majkrzak/333417ea2d7e59f149c51e8016d10962 in #409. The trace shows that holding down the big arrow sends a "move_with_on_off" (COMMAND_MOVE_ON_OFF) event. However, this quirk incorrectly binds the COMMAND_STEP_ON_OFF event instead. This caused long presses on the big arrow to be ignored.
This PR puts the correct event in place.