-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS0201_Zemismart Quirk #989
Conversation
I think that is the right way to do it then the attribute is being sent OK by the device. You can also defining the manufacture cluster if you like and dont need the hex number of it but is not needed if we is not using it in the future. Im not one code worrier do i can only helping with ideas but it can being good some times :-)) Great work done Marcio !! |
@MattWestb Thanks! Can we merge this? |
I cant but the devs can but i dont knowing way they is not merger ready PR that the user need for getting there devices working OK in there systems. By the way great work done !!! |
Maybe @Adminiuga can take a check if can be merged? |
Just override the node descriptor in replacement dict |
Codecov Report
@@ Coverage Diff @@
## dev #989 +/- ##
==========================================
+ Coverage 82.55% 82.58% +0.03%
==========================================
Files 189 190 +1
Lines 4798 4807 +9
==========================================
+ Hits 3961 3970 +9
Misses 837 837
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 1156493113
💛 - Coveralls |
@Adminiuga done! thanks, it looks way better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #988
I tried the solution proposed in the issue, but the problem what that the Device's NodeDescriptor has the MainsPowered flag set.
Clearing the flag whenever the node_descriptor is queried seems to fix the problem!