Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the calibrate option to the attributes. #996

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

SLG
Copy link
Contributor

@SLG SLG commented Aug 16, 2021

See here for more information: home-assistant/core#46146

I've tested it locally and it works like a charm.
I'm not sure if there should be done anything else, or that there will be any potential issues with this fix?

@MattWestb
Copy link
Contributor

If the device is handling the attribute 0xF003 OK the user can calibrating the device from the cluster panel that shall being OK,
Its possible doing more things in the HA side but i think this is the most important for the moment getting in place and some can doing the HA part later if thy like for the devices.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1135657779

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 82.559%

Totals Coverage Status
Change from base Build 1103007488: 0.004%
Covered Lines: 3962
Relevant Lines: 4799

💛 - Coveralls

@dmulcahey dmulcahey merged commit e6591ec into zigpy:dev Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants