Add translation_placeholders to v2 quirks #1668
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for translation_placeholders functionality to the v2 quirks system, allowing entities to have dynamic translation values.
- Adds
translation_placeholdersfield to entity metadata classes - Updates all entity creation methods to accept the new parameter
- Extends entity modification capabilities to include translation placeholder updates
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1668 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 62 62
Lines 12043 12045 +2
=======================================
+ Hits 11960 11962 +2
Misses 83 83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
The changes look good. Thanks!
I can solve the conflict in #1652 later.
|
Any news about this? |
|
Sorry, I'll be aiming to get this into 2025.11. |
| attribute_initialized_from_cache: bool = attrs.field(default=True) | ||
| unique_id_suffix: str | None = attrs.field(default=None) | ||
| translation_key: str | None = attrs.field(default=None) | ||
| translation_placeholders: dict[str, str] | None = attrs.field(default=None) |
There was a problem hiding this comment.
Sorry for missing this. This should have been a frozendict. I'll fix it in a few minutes.
3 participants
Added as kwarg only to avoid breaking changes (may conflict with #1652)
Needed for zigpy/zha#533