Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StaticContentModule #4369

Merged
merged 16 commits into from
Jul 25, 2020
Merged

Add StaticContentModule #4369

merged 16 commits into from
Jul 25, 2020

Conversation

craigh
Copy link
Member

@craigh craigh commented Jul 2, 2020

Q A
Bug fix? no
New feature? yes!
BC breaks? no
Deprecations? no
Fixed tickets -
Refs tickets -
License MIT
Changelog updated yes

Description

Added template display controller for quick generation and display of static template-based content.

To do

- [x] docs
- [x] also add template-based block
- [x] address question of required /p/* in route
- [ ] add permission scheme somewhere

  • move content-blocks to new StaticContentModule
  • update docs
  • update maker (make:zikula-extension) to discourage use of Zikula as vendor
    - [ ] update BlocksModuleInstaller to shift new block creation on install to StaticContentModule and update existing classes.

@craigh craigh added the Feature label Jul 2, 2020
@craigh craigh added this to the 3.1.0 milestone Jul 2, 2020
@craigh craigh requested a review from Guite July 2, 2020 14:12
@craigh craigh self-assigned this Jul 2, 2020
@craigh craigh marked this pull request as draft July 2, 2020 14:15
@craigh

This comment has been minimized.

@Guite

This comment has been minimized.

@craigh craigh changed the title add controller for display of static template-based content add controller and block for display of static template-based content Jul 2, 2020
@craigh craigh marked this pull request as ready for review July 2, 2020 17:23
Copy link
Member

@Guite Guite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea where to provide the permission scheme (component ZikulaCoreBundle::, instance static::)? Maybe in the ExtensionsModule?

@Guite

This comment has been minimized.

@craigh

This comment has been minimized.

@craigh

This comment has been minimized.

@Guite

This comment has been minimized.

@craigh

This comment has been minimized.

@Guite
Copy link
Member

Guite commented Jul 2, 2020

maybe we should reconsider this information collection for a later release.

agreed; it could also be populated programmatically ($someService->populatePermissionScheme())

@craigh

This comment has been minimized.

@Guite
Copy link
Member

Guite commented Jul 3, 2020

I think this would be a use case for adding a custom route (Routes module) to let calendar point to the same controller as p/calendar (additionally).
Centrally adding /{name} would certainly lead to conflicts.

@craigh

This comment has been minimized.

@Guite

This comment has been minimized.

@craigh

This comment has been minimized.

@craigh

This comment has been minimized.

@Guite

This comment has been minimized.

@craigh craigh changed the title add controller and block for display of static template-based content Add StaticContentModule Jul 6, 2020
@Guite

This comment has been minimized.

@craigh
Copy link
Member Author

craigh commented Jul 23, 2020

@Guite I am having second thoughts about removing the contents blocks from Blocks module at 3.1.0. I am thinking full removal should wait until 4.0. In the meantime, I think we should add StaticContent module and deprecate the old blocks with plans to remove at 4.0. In the meantime, we can post an alert to the blocks admin that encourages user to move blocks to StaticContent. Then we don't do anything in the upgrade, etc. thoughts?

@Guite
Copy link
Member

Guite commented Jul 23, 2020

That would indeed be cleaner. Good idea.

@craigh craigh requested a review from Guite July 23, 2020 23:49
@Guite
Copy link
Member

Guite commented Jul 24, 2020

terrific 😃

@craigh craigh merged commit 240151d into master Jul 25, 2020
@craigh craigh deleted the static branch July 25, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants