-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static mesh, new shapes, dynamic color and variable render resolution #47
Conversation
Fixes a bug where if you initialize the static mesh first, the number of frames get set to 1
Add more shapes
Variable resolution and sample per pixel
Add static meshes and vectorfield bugfixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! I have a few comments on the mesh objects I would like to discuss briefly. But overall it looks great.
On a second point, I think we can clean up the data flow in the visualiser and the renderer, however, I think this calls for a different PR so we can shelve that for now. Just check out my mesh comments and we can merge the PR.
I moved the mesh instantiation to the parent |
Shapes like |
The changes passed the tests locally.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes, I just have two comments which could be addressed quickly. And I like the new parent class updates.
Alright, i think now all the changes are adressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Can be added to
vis.Particle
andvis.VectorField
by simply giving them thestatic = True
parameter.Note that static objects only take in position in the shape of
(n_part, n_dim)
Box
,Cone
,Icosahedron
,Octahedron
,Tetrahedron
,Torus
andMobiusLoop
resolution = [4096, 2160]
andspp = 64