#12 #48 WcApp implementation using ZStream #64
Conversation
|
|
TobiasPfeifer
force-pushed
the
wcApp-impl-ZStream-rebase2
branch
from
7815195
to
886a04a
Compare
TobiasPfeifer
force-pushed
the
wcApp-impl-ZStream-rebase2
branch
from
886a04a
to
0673507
Compare
| wordsStream <- if (opts.words) words.optional else ZIO.none | ||
| linesStream <- if (opts.lines) lines.optional else ZIO.none | ||
|
|
||
| bytesFiber <- runCountOrNone(bytesStream).fork |
There was a problem hiding this comment.
Unfortunately you will read the file 4 times. I think you want 4 transducers, each of them doing word / character / line / byte count, and then glue them together, and stick them on the stream. That would be much more efficient than reading the file 4 separate times.
There was a problem hiding this comment.
How do ZTransducer compose in that way? There is not zip on ZTransducers. But I get your point there. I'll implement it using ZSinks. One for each optional count and then zipping them and apply it on the stream.
There was a problem hiding this comment.
It's unfortunate they don't compose (although they can). So yes, I think switching to using ZSink is a good idea.
TobiasPfeifer
force-pushed
the
wcApp-impl-ZStream-rebase2
branch
from
5a018d7
to
4a251f5
Compare
|
@TobiasPfeifer Great work! So nice to see a full-fledged and working example app written using ZIO CLI. |
#12 #48
@jdegoes @iravid for files larger than 1MB this implementation is consuming 100% CPU for way to long. Can you check if there is a flaw in my implementation. Otherwise this is indicating a performance issue in ZStreams