Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 support #246

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Scala 3 support #246

wants to merge 29 commits into from

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Oct 12, 2022

Resolves #225

@vigoo vigoo mentioned this pull request Feb 15, 2023
@KacperFKorban
Copy link

This OOM is fixed on dotty/main, though not backported ATM.
A workaround for this is to add @unchecked to this line


like so:

val _ = (remote: @unchecked) match {

@vigoo
Copy link
Contributor Author

vigoo commented Apr 30, 2023

This OOM is fixed on dotty/main, though not backported ATM. A workaround for this is to add @unchecked to this line

Thanks, nice to hear! But with sbt -mem 8192 it is not OOM but some macro tree check error.

@KacperFKorban
Copy link

I think that the macro check error is a different issue. It's an upstream bug in ZIO.
Without -Xcheck-macros, the runtime tests compile and run for me without any runtime errors.

I think that instead of adding -Xcheck-macros here, it should be added in zio/zio since that is where the macros are defined (and can be fixed).

@vigoo
Copy link
Contributor Author

vigoo commented Apr 30, 2023

I think that instead of adding -Xcheck-macros here, it should be added in zio/zio since that is where the macros are defined (and can be fixed).

Interesting, thanks. Will do that. (This was not obvious to me from the error message at all.)

@vigoo
Copy link
Contributor Author

vigoo commented Apr 30, 2023

So in ZIO adding -Xcheck-macros to the test project did not reveal any error, but anyway I will continue migrating this project by removing that flag for now.

@vigoo vigoo marked this pull request as ready for review April 30, 2023 18:02
Copy link
Member

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some build related suggestions from a random passer by. I hope you may find some of them helpful.
Thanks for working on zio-flow 🙇

project/BuildHelper.scala Outdated Show resolved Hide resolved
}
val Scala212: String = versions("2.12")
val Scala213: String = versions("2.13")
val ScalaDotty: String = versions("3.3")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val ScalaDotty: String = versions("3.3")
val Scala3: String = versions("3")

You may then need to rename a couple of remaining uses of ScalaDotty.

project/BuildHelper.scala Outdated Show resolved Hide resolved
project/BuildHelper.scala Outdated Show resolved Hide resolved
vigoo and others added 3 commits June 1, 2023 10:48
Comment on lines 2 to +4
val Scala212 = "2.12.17"
val Scala213 = "2.13.8"
val Scala3 = "3.2.1"
val Scala3 = "3.3.0-RC4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed. There are versions already defined in BuildHelper.scala.

val (name, age) = Remote.makeAccessors[Person]
def derivedPersonSchema = DeriveSchema.gen[Person]

implicit def schema: Schema[Person] = derivedPersonSchema
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not lazy val?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala 3 support
3 participants