-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala 3 support #246
base: main
Are you sure you want to change the base?
Scala 3 support #246
Conversation
This OOM is fixed on
like so: val _ = (remote: @unchecked) match { |
Thanks, nice to hear! But with |
I think that the macro check error is a different issue. It's an upstream bug in ZIO. I think that instead of adding |
Interesting, thanks. Will do that. (This was not obvious to me from the error message at all.) |
So in ZIO adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some build related suggestions from a random passer by. I hope you may find some of them helpful.
Thanks for working on zio-flow 🙇
project/BuildHelper.scala
Outdated
} | ||
val Scala212: String = versions("2.12") | ||
val Scala213: String = versions("2.13") | ||
val ScalaDotty: String = versions("3.3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val ScalaDotty: String = versions("3.3") | |
val Scala3: String = versions("3") |
You may then need to rename a couple of remaining uses of ScalaDotty
.
Co-authored-by: Ondra Pelech <ondra.pelech@gmail.com>
val Scala212 = "2.12.17" | ||
val Scala213 = "2.13.8" | ||
val Scala3 = "3.2.1" | ||
val Scala3 = "3.3.0-RC4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed. There are versions already defined in BuildHelper.scala
.
val (name, age) = Remote.makeAccessors[Person] | ||
def derivedPersonSchema = DeriveSchema.gen[Person] | ||
|
||
implicit def schema: Schema[Person] = derivedPersonSchema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not lazy val
?
Resolves #225