Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rename command #232

Closed

Conversation

FlorianDoublet
Copy link

No description provided.

@regis-leray
Copy link
Member

regis-leray commented Mar 24, 2022

@FlorianDoublet

Thanks for your contribution.

All the ftp method are exposed by using execute(), i was wondering why do we need to create an alias ?

We are exposing a method inside the FtpClient when we want to have custom logic. In this use case we are only creating an alias. Is there another reason ?

@regis-leray
Copy link
Member

@FlorianDoublet your license approval is fixed. Build is failing you need to run sbt fmt

@FlorianDoublet
Copy link
Author

FlorianDoublet commented Mar 28, 2022

@FlorianDoublet

Thanks for your contribution.

All the ftp method are exposed by using execute(), i was wondering why do we need to create an alias ?

We are exposing a method inside the FtpClient when we want to have custom logic. In this use case we are only creating an alias. Is there another reason ?

Thanks for your reply @regis-leray,

Indeed that's only for an alias purpose, but it was done for the 'rm' command too.
It just could be handy to directly call .rename instead of passing by the execute method, don't you think ?

@regis-leray regis-leray reopened this Mar 28, 2022
@FlorianDoublet
Copy link
Author

@regis-leray the Install JDK step in the CI seems to be broken, so I can't see if anything else is wrong

@regis-leray regis-leray closed this Apr 4, 2022
@regis-leray regis-leray reopened this Apr 4, 2022
@regis-leray
Copy link
Member

looks like the build is broken, need to update the dependencies or move to github action. I created a ticket #235

@regis-leray
Copy link
Member

regis-leray commented May 17, 2022

@FlorianDoublet build is FIXED can you update your PR thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants