Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs appendable to Endpoint, no name req. for out methods in Endpoint #2203

Merged
merged 1 commit into from
May 29, 2023

Conversation

987Nabil
Copy link
Contributor

Also add method to append doc to EndpointMiddleware

fixes #2193
/claim #2193

fixes #2195
/claim #2195

Also add method to append doc to `EndpointMiddleware`

fixes zio#2195
fixes zio#2193
@987Nabil
Copy link
Contributor Author

@jdegoes the algora bot does not seem to support two claims in one PR. Can you help out?

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 16.98% and project coverage change: -0.40 ⚠️

Comparison is base (39dd459) 65.04% compared to head (e235d08) 64.64%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2203      +/-   ##
==========================================
- Coverage   65.04%   64.64%   -0.40%     
==========================================
  Files         143      143              
  Lines        6520     6560      +40     
  Branches      237      240       +3     
==========================================
  Hits         4241     4241              
- Misses       2279     2319      +40     
Impacted Files Coverage Δ
...n/scala/zio/http/endpoint/EndpointMiddleware.scala 74.35% <0.00%> (-1.96%) ⬇️
...tp/src/main/scala/zio/http/endpoint/Endpoint.scala 36.41% <17.30%> (-9.80%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@987Nabil
Copy link
Contributor Author

idk why the performance test is failing. I don't think this changes should affect performance at all. Maybe just a problem in the runner?

@zcesur
Copy link

zcesur commented May 18, 2023

@jdegoes the algora bot does not seem to support two claims in one PR. Can you help out?

hey @987Nabil - both claims are in now 👍

@vigoo
Copy link
Contributor

vigoo commented May 24, 2023

idk why the performance test is failing. I don't think this changes should affect performance at all. Maybe just a problem in the runner?

restarted it

@vigoo vigoo merged commit 1e1be69 into zio:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve multipart vs alternation API of Endpoint Improve API to add Docs to Endpoint in, out and outError
4 participants