Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing default http headers (#2557) #2595

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

987Nabil
Copy link
Contributor

@987Nabil 987Nabil commented Jan 7, 2024

fixes #2557
/claim #2557

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f4b2b3f) 64.23% compared to head (410e6cd) 64.36%.

Files Patch % Lines
zio-http/src/main/scala/zio/http/Header.scala 84.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2595      +/-   ##
==========================================
+ Coverage   64.23%   64.36%   +0.13%     
==========================================
  Files         140      140              
  Lines        8358     8411      +53     
  Branches     1604     1580      -24     
==========================================
+ Hits         5369     5414      +45     
- Misses       2989     2997       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegoes jdegoes merged commit ba1f618 into zio:main Jan 7, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Header implementations
3 participants