Don't share the Scope in ContentTypeSpec
#2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
There seem to be other tests failing now. I'll mark the PR as draft and mark the PR as ready when they're all stable |
|
@jdegoes PR is ready for review. I rerun CI 4 times and it passed. In case the issue comes back in other test suites I'm happy to fix it there as well in a followup PR |
jdegoes
approved these changes
Jun 6, 2024
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fix #2885
/claim #2885
@jdegoes I'm fairly certain that this fixes the issue, but it's hard to tell because I can't replicate it locally. I'll run CI 5-10 times (assuming it passes the first time 😅) to make sure it doesn't happen again.
The reason that this started failing now is that since files are served as streams, my assuption is that sharing the same Scope causes issues as the connections are not properly managed across the different test suites. Note that all the other test suites don't share the same Scope