Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #2963: PartialBooleanAttribute (support no value) #2973

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fixes #2963: PartialBooleanAttribute (support no value) #2973

merged 1 commit into from
Aug 2, 2024

Conversation

jgoday
Copy link
Contributor

@jgoday jgoday commented Jul 20, 2024 •
edited
Loading

fixes #2963
/claim #2963

Added PartialBooleanAttribute, so we can use boolean attributes without specifying a value (optionally).

input(typeAttr := "text", requiredAttr)
input(typeAttr := "text", requiredAttr := false)

If this is a valid approach we can extend it to all
boolean attributes

@algora-pbc algora-pbc bot mentioned this pull request Jul 30, 2024
Closed
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jul 30, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@987Nabil 987Nabil merged commit b9a6443 into zio:main Aug 2, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@987Nabil 987Nabil 987Nabil approved these changes

@jdegoes jdegoes Awaiting requested review from jdegoes jdegoes is a code owner

@vigoo vigoo Awaiting requested review from vigoo vigoo is a code owner

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML Templates can't emit attributes without values
2 participants
@jgoday @987Nabil