With the default ZConnectionPoolConfig if the connection fails, it'll retry forever to try to connect and will deadlock the program
#174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
force-pushed
the
fix_forever_hang
branch
from
8f00052
to
6339ad6
Compare
…ll retry forever to connect and deadlock the program
guizmaii
force-pushed
the
fix_forever_hang
branch
from
6339ad6
to
80e74e1
Compare
guizmaii
changed the title
ZConnectionPoolConfig if the connection fails, it'll retry forever to connect and deadlock the programZConnectionPoolConfig if the connection fails, it'll retry forever to try to connect and will deadlock the program
guizmaii
commented
Oct 27, 2023
| @@ -32,7 +32,8 @@ object ZConnectionPoolConfig { | |||
|
|
|||
| lazy val default: ZConnectionPoolConfig = ZConnectionPoolConfig(8, 32, defaultRetryPolicy, 300.seconds) | |||
|
|
|||
| lazy val defaultRetryPolicy: Schedule.WithState[Long, Any, Any, Duration] = Schedule.exponential(10.millis) | |||
| lazy val defaultRetryPolicy: Schedule.WithState[(Long, Long), Any, Any, (Long, Duration)] = | |||
| Schedule.recurs(10) && Schedule.exponential(15.millis) | |||
There was a problem hiding this comment.
Why 10 and 15.millis here? Because if my math is correct, it'll make the user wait for max 30 seconds.
adamgfraser
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.