Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply ZIO project template #21

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Apply ZIO project template #21

merged 2 commits into from
Sep 22, 2020

Conversation

fsvehla
Copy link
Contributor

@fsvehla fsvehla commented Sep 22, 2020 •
edited
Loading

Closes #9

  • applies project template
  • Update Scala / Scala.js versions to what zio/zio currently uses
  • Fix Scala 2.12 build

A few notes:

  • Scala.JS tests currently don’t work because files are read from resources
  • This changes the license
  • Currently, as per the template only John is listed in the contributors

jdegoes
jdegoes approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@jdegoes jdegoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tremendous refactoring!

@fsvehla
Copy link
Contributor Author

fsvehla commented Sep 22, 2020

@jdegoes conflicts resolved

@jdegoes jdegoes merged commit 8c11874 into zio:develop Sep 22, 2020
@jdegoes
Copy link
Member

jdegoes commented Sep 22, 2020

Merged, thank you! 🔥

@fsvehla fsvehla mentioned this pull request Sep 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes jdegoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert over to the standard ZIO project template
2 participants
@fsvehla @jdegoes