Remove trailing comma from labels in prometheus encoding #62
Conversation
Here is an example line from the prometheus encoding:
```
summary{error="0.03",quantile="0.1",} 138.0625
```
According to the [prometheus text based format](https://prometheus.io/docs/instrumenting/exposition_formats/#text-based-format) the trailing comma should not be there.
There was a problem hiding this comment.
Thank you @erikvanoosten! I think this is a cleaner representation so I will merge this, but I am a bit confused if putting a comma at the end is really not supported. Can we discuss this first? Did you experience some issues with prometheus in an actual application?
The linked site contains this snippet, which in my interpretation allows an optional comma after the last label
metric_name [
"{" label_name "=" `"` label_value `"` { "," label_name "=" `"` label_value `"` } [ "," ] "}"
] value [ timestamp ]
|
Hi @petoalbert . I think you are right. I had not looked at the BNF expression too closely, I mostly looked at the examples. But indeed, on closer inspection there is indeed an optional comma at the end. BTW, no, I didn't actually use this project yet (I will soon) so I did not experience any compatibility problems. |
|
Okay, anyway I'll merge this because not having a trailing comma is cleaner in my opinion. I am happy to hear that you will use this project. 🙂 |
Here is an example line from the prometheus encoding:
According to the prometheus text based format the trailing comma should not be there.