Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Product and Serializable interfaces to These #1127

Merged
merged 1 commit into from
May 25, 2023
Merged

Add Product and Serializable interfaces to These #1127

merged 1 commit into from
May 25, 2023

Conversation

erdeszt
Copy link
Contributor

@erdeszt erdeszt commented May 25, 2023

It helps with type inference and with avoiding issues where unrelated types are pushed into the same collection(see the Product and Serializable warts here: https://www.wartremover.org/doc/warts.html)

@erdeszt erdeszt requested a review from a team as a code owner May 25, 2023 10:43
sideeffffect
sideeffffect approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally, thanks!

@sideeffffect sideeffffect enabled auto-merge (squash) May 25, 2023 15:44
@sideeffffect sideeffffect merged commit 2bd62cc into zio:series/2.x May 25, 2023
@erdeszt erdeszt deleted the these-product-serializable branch May 25, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgfraser adamgfraser adamgfraser approved these changes

@sideeffffect sideeffffect sideeffffect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erdeszt @sideeffffect @adamgfraser