Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report query compilation times when compiling the code #254

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

arturaz
Copy link
Contributor

@arturaz arturaz commented Mar 14, 2023

Problem

When you have a complex query it can take a long time to compile. The compile time can be sped up by rewriting it as raw SQL query. This helps to determine which queries are the ones that are worth rewriting by looking at how long they compile.

Solution

Quill now reports how much time it took to compile this query.

@getquill/maintainers

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2023

CLA assistant check
All committers have signed the CLA.

@juliano
Copy link
Collaborator

juliano commented Jun 28, 2023

@arturaz thanks for this! I think there should be a switch in io.getquill.util.Messages to enable/disable it. Could you please add that and then I'll merge. Thanks!

@juliano
Copy link
Collaborator

juliano commented Jun 28, 2023

NVM, it's already using io.getquill.util.Messages.debugEnabled. Thank you for your contribution!

@juliano juliano merged commit 2c35294 into zio:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants