Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finagle-Postgres support #8

Closed
vkostyukov opened this issue Dec 3, 2015 · 2 comments
Closed

Finagle-Postgres support #8

vkostyukov opened this issue Dec 3, 2015 · 2 comments

Comments

@vkostyukov
Copy link

It would be abolutelly awesome to support finagle-postgres in Quill. I'm might volunteer and give it a try, althought I can't promise any progress in the nearest feature, so I decided to open an issue so anyone else can pick it up.

@fwbrasil
Copy link
Collaborator

fwbrasil commented Dec 5, 2015

Thanks for creating this issue @vkostyukov. postgresql-async has some performance issues, so It'd be nice to have an alternative!

It should be straightforward to implement using quill-finagle-mysql as example. There are two things that seem to be different though:

  1. I couldn't find transaction support in finagle-postgres. Is it available?
  2. The encoders and decoders will be a bit different since finagle-postgres doesn't provide a high-level api for parameters and results as finagle-mysql does.

Let me know if I can be of any help.

@jilen
Copy link
Collaborator

jilen commented Jul 2, 2016

The new finagle-postgres implementation is call roc

@jilen jilen mentioned this issue Sep 15, 2016
5 tasks
jilen pushed a commit that referenced this issue Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants