Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encoder/decoder for Byte #1143

Merged
merged 3 commits into from
Aug 21, 2018
Merged

Add encoder/decoder for Byte #1143

merged 3 commits into from
Aug 21, 2018

Conversation

juliano
Copy link
Collaborator

@juliano juliano commented Aug 20, 2018

Fixes #1029

Problem

Missing Encoder/Decoder for Byte.

Solution

Added them!

Notes

Additional notes.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@juliano juliano force-pushed the orientdb-byte-encoder-decoder branch from a2bca29 to 6cd214f Compare August 20, 2018 15:38
mosyp
mosyp approved these changes Aug 21, 2018
View reviewed changes
Copy link
Collaborator

@mosyp mosyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@juliano
Copy link
Collaborator Author

juliano commented Aug 21, 2018

@mentegy updated as well :)

@mosyp mosyp merged commit 84cc55d into zio:master Aug 21, 2018
@juliano juliano deleted the orientdb-byte-encoder-decoder branch August 21, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosyp mosyp mosyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliano @mosyp