Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicValue.schema made public #392

Closed
wants to merge 2 commits into from
Closed

DynamicValue.schema made public #392

wants to merge 2 commits into from

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Oct 27, 2022

Resolves #332

@vigoo vigoo requested a review from a team as a code owner October 27, 2022 16:46
@jdegoes
Copy link
Member

jdegoes commented Oct 27, 2022

Lint is failing.

@vigoo
Copy link
Contributor Author

vigoo commented Oct 27, 2022

I know will finish it later (went back to the stack safety topic for now)

@jdegoes
Copy link
Member

jdegoes commented Oct 30, 2022

Please just re-open when you have a chance to get the build passing!

@jdegoes jdegoes closed this Oct 30, 2022
@vigoo vigoo mentioned this pull request Dec 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DynamicValueSchema should not be private
2 participants
@vigoo @jdegoes