Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split db-specific Module traits into more specialized parts #637

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

jczuchnowski
Copy link
Member

@jczuchnowski jczuchnowski commented Apr 27, 2022

This PR splits db-specific *Module traits into specialized parts with clear dependencies:

  • *SqlModule - for db-specific DSL extensions
  • *RenderModule - for the SQL rendering logic (depends on *SqlModule)
  • *JdbcModule - final module for the end-user (combines *RenderModule with Jdbc)

Reasoning behind the change:

  • db-specific Module traits became too large
  • DSL should be separate from the rendering logic
  • rendering logic and DSL should be separate from the driver implementation (JDBC)
  • allows for different combinations of rendering logic implementations and drivers other than JDBC

@jczuchnowski jczuchnowski requested a review from a team as a code owner April 27, 2022 23:03
@jdegoes jdegoes merged commit 814bf70 into zio:master Apr 28, 2022
@jczuchnowski jczuchnowski deleted the module-refactor branch April 28, 2022 09:51
amrkamel pushed a commit to amrkamel/zio-sql that referenced this pull request May 26, 2022
Split db-specific Module traits into more specialized parts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants