Add SqlTransaction type #692
Conversation
| import zio.schema.Schema | ||
|
|
||
| trait ExprSyntaxModule { self: Jdbc => | ||
| implicit final class ReadSyntax[A](self: Read[A]) { |
There was a problem hiding this comment.
imo this end up being the best end-user syntax.
There was a problem hiding this comment.
what about toZIO ?
imho It seems weird from user perspective to have to call both transact and run.
Ideally if we could omit calling run somehow....how ZIO JDBC does that?
But overall this is great simplification, I'll let also @jczuchnowski review
There was a problem hiding this comment.
I'm not sure.
The semantics are that you will run the individual statements when you use run on them, but only commit them after the transact scope is done.
I think we should pick naming that makes this very clear.
Maybe withTransaction instead of transact?
| @@ -37,4 +44,7 @@ trait Jdbc extends zio.sql.Sql with TransactionModule with JdbcInternalModule wi | |||
|
|
|||
| def execute(update: Update[_]): ZIO[SqlDriver, Exception, Int] = | |||
There was a problem hiding this comment.
We may want to rename this to make clearer that it does not run as part of a transaction
resolves #665