Implement renderInsert for Oracle #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I don't if I should get rid of the duplications between the Postgres module and this one. |
|
@peixunzhang seems that some tests have problems, can you please check? |
* wip * wip * wip * formatting * Insert tests * Update oracle/src/test/scala/zio/sql/oracle/OracleSqlModuleSpec.scala Co-authored-by: PeiZ <74068135+peixunzhang@users.noreply.github.com>
sviezypan
reviewed
Jun 28, 2022
| @@ -55,6 +58,13 @@ trait JdbcRunnableSpec extends ZIOSpecDefault with Jdbc { | |||
| SqlDriver.live | |||
| ) | |||
|
|
|||
| protected implicit def genInstances[R] | |||
There was a problem hiding this comment.
Hi,
It is used to generate data for testing here:
https://github.com/zio/zio-sql/pull/695/files#diff-95c65e34d1de6f688c0376b4d84612f8fb80a163383f605194932ac51b427fcfR169
| durationCol | ||
| ).values(row) | ||
|
|
||
| // TODO: ensure we can read values back correctly |
There was a problem hiding this comment.
has this worked? test like this would be awesome!
There was a problem hiding this comment.
Hi,
if I remember correctly there was some issue with reading the data back. Can't check right now because of m1 chip.
Long term we should definitely enable this test.
jczuchnowski
approved these changes
Jul 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.