#707 Added support for SumInt(Int), SumDec(BigDecimal) and AvgDec(BigDecimal) #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sviezypan
requested changes
Oct 28, 2022
| def spec = suite("Aggregate Expression")( | ||
| test("+ works on integer, Double and BigDecimal columns") { | ||
| val query = agSelect | ||
| assert(query)(anything) |
There was a problem hiding this comment.
not sure what you're testing here....what's agSelect ?
There was a problem hiding this comment.
Added new enhanced Test AgregationSpec for Postgesql
and removed core/jvm/src/test/scala/zio/sql/ExprSpec.scala
There was a problem hiding this comment.
The CI-build seems to be flaky my local build was successful
37 tests passed. 0 tests failed. 1 tests ignored.
Executed in 6 m 15 s
sviezypan
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to support for SumInt(Int), SumDec(BigDecimal) and AvgDec(BigDecimal)