Skip to content

Get rid of deprecated .should syntax in readme #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2019
Merged

Get rid of deprecated .should syntax in readme #447

merged 1 commit into from
Sep 18, 2019

Conversation

psy-q
Copy link
Contributor

@psy-q psy-q commented Sep 18, 2019

I know we all mentally substitute .should with expect() already, but why keep the mental burden? 😉

oestrich
oestrich approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@oestrich oestrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oestrich oestrich merged commit 81e5c56 into zipmark:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@oestrich oestrich oestrich approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psy-q @oestrich