Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make carriers work #42

Closed
zippy opened this issue Sep 24, 2015 · 2 comments
Closed

make carriers work #42

zippy opened this issue Sep 24, 2015 · 2 comments
Assignees
@zippy

Comments

@zippy
Copy link
Owner

zippy commented Sep 24, 2015

This means adding a carrier symbol into signal envelopes (which is just the same as the body symbol) which is used for two things:

  1. for new signals, to pre-select which ones to run the semtrex matcher on based on the carrier of the expectation listener
  2. for responses, as an integrity check to make sure the response matches what you are actually expecting, and if it doesn't to just discard the response as invalid
@zippy zippy self-assigned this Sep 24, 2015
@zippy zippy removed the in progress label Sep 24, 2015
@zippy zippy mentioned this issue Sep 25, 2015
Closed
@zippy zippy closed this as completed Sep 25, 2015
@zippy zippy removed the in progress label Sep 25, 2015
@zippy zippy reopened this Sep 25, 2015
@zippy
Copy link
Owner Author

zippy commented Sep 25, 2015

still need the to add the code in to add_listener / deliver_signal to only match expectations for signals on the correct carriers

zippy added a commit that referenced this issue Sep 28, 2015
@zippy
added carrier handling into signaling #42
5b7ee7e
@zippy zippy added partial and removed in progress labels Oct 15, 2015
zippy added a commit that referenced this issue Nov 14, 2015
@zippy
wip adding until into expectations (LISTEN) #69
bae6d60 
this also lead to completing #42 as we now pre-check
carriers before matching expectation patterns

also the led to adding carriers into the protocol step
@zippy
Copy link
Owner Author

zippy commented Nov 14, 2015

bae6d60 now checking carrier in test_expectation

@zippy zippy closed this as completed Nov 14, 2015
@zippy zippy removed the partial label Nov 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zippy zippy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zippy