Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples that load settings from sample data #50

Merged

Conversation

SatjaSivcev
Copy link
Contributor

@SatjaSivcev SatjaSivcev commented Dec 7, 2021

This PR requires modifying SapleData before merging.

@SatjaSivcev SatjaSivcev requested a review from chrisasc December 7, 2021 19:17
Copy link
Contributor

@chrisasc chrisasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only review the last commit.

Update samples that read settings from sample data,
because settings folder name have changed,
e.g. "Zivid One" to "zividOne".
@SatjaSivcev SatjaSivcev force-pushed the update-samples-that-load-settings-from-sample-data branch from 6d8d651 to f1a214f Compare December 8, 2021 07:38
@SatjaSivcev SatjaSivcev marked this pull request as ready for review January 5, 2022 14:42
@SatjaSivcev SatjaSivcev merged commit b27fa1f into master Jan 5, 2022
@SatjaSivcev SatjaSivcev deleted the update-samples-that-load-settings-from-sample-data branch January 5, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants