Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -358,12 +358,10 @@ where
let uses = step_uses(de)?;

match uses {
Uses::Local(local) if local.git_ref.is_none() => Err(de::Error::custom(
"local action must have `@<ref>` in reusable workflow",
)),
Uses::Repository(repo) if repo.git_ref.is_none() => Err(de::Error::custom(
"repo action must have `@<ref> in reusable workflow",
)),
// NOTE: local reusable workflows do not have to be pinned.
Uses::Local(_) => Ok(uses),
Uses::Repository(_) => Ok(uses),
// `docker://` is never valid in reusable workflow uses.
Expand Down
11 changes: 11 additions & 0 deletions tests/sample-workflows/reusable-workflow-unpinned.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# see https://github.com/woodruffw/zizmor/issues/431

name: "reusable-workflow-unpinned"

on:
push:

jobs:
testcase:
name: "testcase"
uses: ./.github/workflows/reusable.yml
10 changes: 6 additions & 4 deletions tests/test_workflow.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ fn load_workflow(name: &str) -> Workflow {
fn test_load_all() {
let sample_workflows = Path::new(env!("CARGO_MANIFEST_DIR")).join("tests/sample-workflows");

for sample_action in std::fs::read_dir(sample_workflows).unwrap() {
let sample_workflow = sample_action.unwrap().path();
let workflow_contents = std::fs::read_to_string(sample_workflow).unwrap();
serde_yaml::from_str::<Workflow>(&workflow_contents).unwrap();
for sample_workflow in std::fs::read_dir(sample_workflows).unwrap() {
let sample_workflow = sample_workflow.unwrap().path();
let workflow_contents = std::fs::read_to_string(&sample_workflow).unwrap();

let wf = serde_yaml::from_str::<Workflow>(&workflow_contents);
assert!(wf.is_ok(), "failed to parse {sample_workflow:?}");
}
}

Expand Down
Loading