Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional arguments in define_clones #280

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Conversation

zktuong
Copy link
Owner

@zktuong zktuong commented Jul 10, 2023

Add an argument to define_clones to accept a list of additional arguments.

This also works in the singularity image version where any additional arguments can be provided as per normal and it will get parsed accordingly.

closes #279

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #280 (979aa3c) into master (f3fdf6b) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   82.24%   82.21%   -0.04%     
==========================================
  Files          47       47              
  Lines        9064     9065       +1     
==========================================
- Hits         7455     7453       -2     
- Misses       1609     1612       +3     
Flag Coverage Δ
unittests 82.21% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandelion/preprocessing/_preprocessing.py 70.50% <ø> (ø)
dandelion/preprocessing/external/_preprocessing.py 67.52% <100.00%> (ø)
dandelion/tools/_tools.py 86.09% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@zktuong zktuong merged commit 708ffe2 into master Jul 11, 2023
14 checks passed
@zktuong zktuong deleted the update-cmd-for-external branch July 17, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define clones within each group
1 participant