Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define clones within each group #279

Closed
Ngort opened this issue Jul 7, 2023 · 3 comments · Fixed by #280
Closed

Define clones within each group #279

Ngort opened this issue Jul 7, 2023 · 3 comments · Fixed by #280
Labels
enhancement New feature or request

Comments

@Ngort
Copy link

Ngort commented Jul 7, 2023

Is your feature request related to a problem?

I have data from multiple replicates pooled together, each with an identity assigned by a metadata column. I want the defined clones to be within each group, and the edges across groups to be of zero weight.

Right now the DefineClones.py code run is defined as:

    cmd = [
        "DefineClones.py",
        "-d",
        h_file1,
        "-o",
        h_file2,
        "--act",
        action,
        "--model",
        model,
        "--norm",
        norm,
        "--dist",
        str(dist_),
        "--nproc",
        str(nproc),
        "--vf",
        v_field,
    ]

Could we add something that serves as argument for --gf aka --group_fields?

Describe the solution you'd like

I want the defined clones to be within each group, and the edges across groups to be of zero weight.

Describe alternatives you've considered

Slicing the data and running the algorithm.

Additional context

No response

@Ngort Ngort added the enhancement New feature or request label Jul 7, 2023
@zktuong
Copy link
Owner

zktuong commented Jul 10, 2023

Hi @Ngort, thanks - yes i can certainly add this.

I'm currently thinking if i add a free form list [] that you can specify that option, and any other options so it would be like:

cmd_final = cmd + user_additional_cmd

zktuong added a commit that referenced this issue Jul 10, 2023
@zktuong
Copy link
Owner

zktuong commented Jul 10, 2023

can you try install the version at #280

pip install git+https://www.github.com/zktuong/dandelion@update-cmd-for-external

and let me know if this works?

ddl.tl.define_clones(..., additional_args = ['--gf', GROUP_FIELD, ]) # if separate each entry in GROUP_FIELD into its own string if there's multiple

@Ngort
Copy link
Author

Ngort commented Jul 10, 2023

This is perfect! It works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants