Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring how external scripts and locations are called #288

Merged
merged 21 commits into from
Jul 19, 2023
Merged

Conversation

zktuong
Copy link
Owner

@zktuong zktuong commented Jul 17, 2023

Main thing is to refactoring code to call external scripts and locations more cleanly

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #288 (5d3b9cf) into master (464c4a3) will increase coverage by 0.56%.
The diff coverage is 90.80%.

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   82.21%   82.78%   +0.56%     
==========================================
  Files          47       47              
  Lines        9065     8514     -551     
==========================================
- Hits         7453     7048     -405     
+ Misses       1612     1466     -146     
Flag Coverage Δ
unittests 82.78% <90.80%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandelion/__init__.py 100.00% <ø> (ø)
dandelion/logging/__init__.py 100.00% <ø> (ø)
dandelion/logging/_badge.py 100.00% <ø> (ø)
dandelion/logging/_logging.py 100.00% <ø> (ø)
dandelion/logging/_metadata.py 77.77% <ø> (-2.23%) ⬇️
dandelion/plotting/__init__.py 100.00% <ø> (ø)
dandelion/plotting/_plotting.py 82.73% <ø> (-0.06%) ⬇️
dandelion/preprocessing/__init__.py 100.00% <ø> (ø)
dandelion/preprocessing/external/__init__.py 100.00% <ø> (ø)
dandelion/tools/__init__.py 100.00% <ø> (ø)
... and 35 more

@zktuong zktuong merged commit e293c8d into master Jul 19, 2023
15 checks passed
@zktuong zktuong deleted the path-update branch September 29, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant