Support compression levels >= 10 and use zstd's internal default level. #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zstd supports regular compression levels 1 through 22. The special level 0 indicates to use zstd's internal default (currently level 3).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zstd supports regular compression levels 1 through 22. This change enables minizip to accept command-line options of "-10" and above to set levels higher than 10.
This also changes minizip to send the special level of 0 when no command-line level option is specified, which indicates to use zstd's internal default level (currently 3, but potentially subject to change).
zstd also supports negative compression level values to enable "fast" compression. These levels disable Huffman coding to achieve high bandwidth for streaming loads (comparable to LZ4). I didn't attempt to support negative levels here as I'm not sure they're of much value in a non-streaming archive format.