Fix for Log4j2 unreadable logs issue #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbagmar
added a commit
that referenced
this pull request
Jan 19, 2024
* updated appium-device-fram to 8.3.11 * Electron App Setup (#415) * setup for electron application * updated script --------- Co-authored-by: Vaishnavi <vaishnavi.b@ril.com> * fix issue related to test completion * updated pacakge-lock * [Teswiz Enhancement] Browser version support for electron and web testing (#417) * Update README with latest commit ID - ead256d * Replacing selenium maximize function with toolkit screen size * Update README with latest commit ID - 38d12f0 * revert readme changes * Update readme * Update README with latest commit ID - cdd79d5 * Update README with latest commit ID - 839541f * Add electron app platform and driver version * Update README with latest commit ID - 1471e71 * Update README with latest commit ID - 381b239 * Rename variable name * Update README with latest commit ID - 80a6454 * Adding web driver manager for browser version for electron application * electron app context variable * Update README with latest commit ID - ac61286 * removing aplitools * Update README with latest commit ID - 1570397 * Update README with latest commit ID - 4e2ae6c * Update README with latest commit ID - 80a6454 * Adding web driver manager for browser version for electron application * electron app context variable * removing aplitools * Update README with latest commit ID - ac61286 * Update README with latest commit ID - 792db0f * removing electron context parameter * Update README with latest commit ID - fc215fa * Update README with latest commit ID - d4925fb * reverting toolkit changes * Update README with latest commit ID - ad3f912 * remove println statements * adding browser version in schema * Update README with latest commit ID - a7d9ce8 * remove sys out statements * Update README with latest commit ID - b4707fc * Fetching browser version from command line * Fetching file name for windows * Update README with latest commit ID - 28886ca * Adding browser version for web test for chrome browser * Modifying the method to get fileName * Update README with latest commit ID - 59dae88 * Update README with latest commit ID - 23b29aa * change the webdriver manager version parameter and change the browser schema details * Update README with latest commit ID - b8619fd * change the app name in the binary in browser config * Update README with latest commit ID - 85c91c1 --------- Co-authored-by: GitHub Actions <actions@github.com> * updated github build action * updated dependencies * refactoring - addWindowSizeToChromeOptions * updated indentation * Update README with latest commit ID - cb3d0f3 (#463) Co-authored-by: GitHub Actions <actions@github.com> * JioMeet Sample Test case for Electron Application (#467) * Update README with latest commit ID - ead256d * Replacing selenium maximize function with toolkit screen size * Update README with latest commit ID - 38d12f0 * revert readme changes * Update readme * Update README with latest commit ID - cdd79d5 * Update README with latest commit ID - 839541f * Add electron app platform and driver version * Update README with latest commit ID - 1471e71 * Update README with latest commit ID - 381b239 * Rename variable name * Update README with latest commit ID - 80a6454 * Adding web driver manager for browser version for electron application * electron app context variable * Update README with latest commit ID - ac61286 * removing aplitools * Update README with latest commit ID - 1570397 * Update README with latest commit ID - 4e2ae6c * Update README with latest commit ID - 80a6454 * Adding web driver manager for browser version for electron application * electron app context variable * removing aplitools * Update README with latest commit ID - ac61286 * Update README with latest commit ID - 792db0f * removing electron context parameter * Update README with latest commit ID - fc215fa * Update README with latest commit ID - d4925fb * reverting toolkit changes * Update README with latest commit ID - ad3f912 * remove println statements * adding browser version in schema * Update README with latest commit ID - a7d9ce8 * remove sys out statements * Update README with latest commit ID - b4707fc * Fetching browser version from command line * Fetching file name for windows * Update README with latest commit ID - 28886ca * Adding browser version for web test for chrome browser * Modifying the method to get fileName * Update README with latest commit ID - 59dae88 * Update README with latest commit ID - 23b29aa * change the webdriver manager version parameter and change the browser schema details * Update README with latest commit ID - b8619fd * change the app name in the binary in browser config * Update README with latest commit ID - 85c91c1 * Jio Meet single user test case to mute and unmute after user signin * JioMeet sample test, removing extra code from BL and Steps adding test data for electron app * JioMeet sample test case refactoring. Made Changes to the in meeting screen web, stes and test data * change start meeting locator and remove unused imports * remove test annotation * updated the get Meeting Id method by using the javascript executor and start instant meeting --------- Co-authored-by: GitHub Actions <actions@github.com> * [Electron enhancement] Window Handle for electron application for multiple execution (#486) * Update README with latest commit ID - ead256d * Replacing selenium maximize function with toolkit screen size * Update README with latest commit ID - 38d12f0 * revert readme changes * Update readme * Update README with latest commit ID - cdd79d5 * Update README with latest commit ID - 839541f * Add electron app platform and driver version * Update README with latest commit ID - 1471e71 * Update README with latest commit ID - 381b239 * Rename variable name * Update README with latest commit ID - 80a6454 * Adding web driver manager for browser version for electron application * electron app context variable * Update README with latest commit ID - ac61286 * removing aplitools * Update README with latest commit ID - 1570397 * Update README with latest commit ID - 4e2ae6c * Update README with latest commit ID - 80a6454 * Adding web driver manager for browser version for electron application * electron app context variable * removing aplitools * Update README with latest commit ID - ac61286 * Update README with latest commit ID - 792db0f * removing electron context parameter * Update README with latest commit ID - fc215fa * Update README with latest commit ID - d4925fb * reverting toolkit changes * Update README with latest commit ID - ad3f912 * remove println statements * adding browser version in schema * Update README with latest commit ID - a7d9ce8 * remove sys out statements * Update README with latest commit ID - b4707fc * Fetching browser version from command line * Fetching file name for windows * Update README with latest commit ID - 28886ca * Adding browser version for web test for chrome browser * Modifying the method to get fileName * Update README with latest commit ID - 59dae88 * Update README with latest commit ID - 23b29aa * change the webdriver manager version parameter and change the browser schema details * Update README with latest commit ID - b8619fd * change the app name in the binary in browser config * Update README with latest commit ID - 85c91c1 * Handle windows for electron application * Update README with latest commit ID - dedff14 * Update README with latest commit ID - 2e75caf * Adding electronAppLoadingPage and electronAppLoadTime parameter in browser config, and adding toolkit for screen size in electron app visual test * Update README with latest commit ID - a580459 * Removing Loggers, and adding sample app binary value * Update README with latest commit ID - 9e075ef * reportportal changes * Update README with latest commit ID - 84775a4 * reportportal parameter * Update README with latest commit ID - b74cd8d * Adding while Loop for window handle and throws exception after electronAppLoadTime * Update README with latest commit ID - 6750539 * Adding loggers for window handle in electron application * Update README with latest commit ID - 29fee24 * Adding individual import for java utils * Update README with latest commit ID - dd25bc2 --------- Co-authored-by: GitHub Actions <actions@github.com> * use ATD with updated dependencies (potential v14.0.2) * use Applitools 5.66.3 * use ATD from log4jIssue branch which uses log4j plugin processor * do not pull latest code in github actions. it should already be the latest * check git status before updating commit id * use BRANCH_NAME in github actions * github actions - update README only if running in main * set IS_VISUAL=false for electron app * gs * updated build.gradle.sample * use updated ATD "74c6f09ffc" // ATD from log4jIssue branch - added log4j plugin processor, reverted reportportal dependency versions * get branch name correctly (instead of HEAD in CI) * reverted to ATD 14.0.1 * Use ATD 964db36c1e - log4x 2.x, latest reportportal dependencies. all other dependencies as per 14.0.1 * atdVersion - 425ebdf693 // log4jIssue - log4x 2.x, all other dependencies as per 14.0.1 * use log4j bridge in teswiz * revert to earlier way of getting branch name using 'git rev-parse --abbrev-ref HEAD' * add browserVersion in browser_headless_config.json * added test to demonstrate how to override the default BROWSER_CONFIG_FILE provided in the config.properties * removed unnecessary log statements in ReportPortalLogger * updated ATD (updateDependencies branch) - 5a6a3bf160 * use the same browser config in the test to override the default one * Fix for Log4j2 unreadable logs issue (#522) * Added support for Log4j2PluginsCacheFileTransformer * Added exclude Log4j2Plugins.dat --------- Co-authored-by: Aman.Daharwal <aman.daharwal@ril.com> * revert to applitools v5.66.3 * Updated Log4j 2.x Apis (#523) * Added support for Log4j2PluginsCacheFileTransformer * Added exclude Log4j2Plugins.dat * updated log4j references with logging.log4j and LogManager * removed log4j2 references from gradle * removed migration of Log4j1 to Log4j2 from Runner --------- Co-authored-by: Aman.Daharwal <aman.daharwal@ril.com> * Catch any internal exception that may be thrown and fail the test run accordingly * updated to Applitools 5.66.4 * updated calculator capabilities and config properties * Browser stack web issue (#544) * commented if block and added localidentifier * removed comment and added localIdentifier --------- Co-authored-by: Aman.Daharwal <aman.daharwal@ril.com> * updated package.json * updated calculator capabilities for pCloudy and updated pCloudySetup based on appium 2.x * updated capabilites, configs and small refactoring in PCloudySetup.java * removed appium-dashboard plugin * updated caps * updated ATD version - revertDeviceFarmUrl branch * do not terminate app if it is the driver created by ATD * Updated to log4j2 properties (#550) * added reconfiguration of log4j2 in setLogPropertiesFile * added log4j2.properties * replaced PropertyConfigurator with LoggerContext * updated log4j2.properties file * updated log4j2.properties file reference in .properties file * updated log4j2.properties file reference in .README.md * added default log4j.properties file * removed log4j.properties and default log4j.properties file --------- Co-authored-by: Aman.Daharwal <aman.daharwal@ril.com> * updated ATD to 70c9e51052 - latest from the revertDeviceFarmUrl branch * updated to appium-device-farm 8.4.6 * use revertDeviceFarmUrl-SNAPSHOT // revertDeviceFarmUrl branch (70c9e51052) * updated github action * ignore caret in new calculator test * removed selenium-http-jdk-client and updated to applitools 5.66.5 * updated npm packaged and git hub action * When printing the environment variables and system properties, exclude variables containing the name "key, password" and ""java.class.path, java.library.path" respectively * create separate workflow for TheApp tests and calculator tests * split the android tests in 2 separate workflows --------- Co-authored-by: vaishnavibawankule <40891223+vaishnavibawankule@users.noreply.github.com> Co-authored-by: Vaishnavi <vaishnavi.b@ril.com> Co-authored-by: MedhaGupta-Ril <122343539+MedhaGupta-Ril@users.noreply.github.com> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: aman <89586972+AmanDaharwal@users.noreply.github.com> Co-authored-by: Aman.Daharwal <aman.daharwal@ril.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fix for Log4j2 unreadable logs issue - #506
Excluded the Log4j2Plugins.dat ( cache file is included in the jar. )
If a dependency contains log4j2 plugin, a Log4j2Plugins.dat cache file is included in the jar. When the Maven shade plugin is used to merge multiple jars with a Log4j2Plugins.dat file, only one will survive. Without the plugin definitions, errors are shown on startup. [Log4j2 issue]