Skip to content

Conversation

paulodamaso
Copy link
Contributor

For #18: Update qulice to version 0.17.4.

  • Upgraded qulice to version 0.17.4 and corrected failures.

@0crat
Copy link
Collaborator

0crat commented Jul 13, 2018

Job #36 is now in scope, role is REV

@0crat 0crat added the scope label Jul 13, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 13, 2018

Job #36 is already in scope

@codecov-io
Copy link

codecov-io commented Jul 13, 2018

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #36   +/-   ##
========================================
  Coverage      92.1%   92.1%           
  Complexity       17      17           
========================================
  Files             3       3           
  Lines            38      38           
  Branches          1       1           
========================================
  Hits             35      35           
  Misses            3       3
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/zold/api/Wallet.java 91.66% <ø> (ø) 0 <0> (ø) ⬇️
src/main/java/io/zold/api/RtTransaction.java 94.44% <ø> (ø) 13 <0> (ø) ⬇️
src/main/java/io/zold/api/WalletsIn.java 87.5% <ø> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0179105...6359671. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented Jul 14, 2018

This pull request #36 is assigned to @carlosmiranda/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

Copy link
Contributor

@carlosmiranda carlosmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale no comments, looks good to merge

@llorllale
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 16, 2018

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 6359671 into zold-io:master Jul 16, 2018
@rultor
Copy link
Contributor

rultor commented Jul 16, 2018

@rultor merge

@llorllale Done! FYI, the full log is here (took me 12min)

@0crat
Copy link
Collaborator

0crat commented Jul 16, 2018

Job #36 is not in the agenda of @carlosmiranda/z, can't retrieve data and time of add

@0crat
Copy link
Collaborator

0crat commented Jul 16, 2018

Job #36 is not in the agenda of @carlosmiranda/z, can't retrieve data and time of add

@0crat
Copy link
Collaborator

0crat commented Jul 16, 2018

Job #36 is not in the agenda of @carlosmiranda/z, can't inspect

@0crat 0crat removed the scope label Jul 16, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 16, 2018

The job #36 is now out of scope

@ypshenychka
Copy link

@0crat status

@0crat
Copy link
Collaborator

0crat commented Oct 10, 2018

@0crat status (here)

@ypshenychka This is what I know about this job in CAZUREFND, as in §32:

@ypshenychka
Copy link

@carlosmiranda According to our QA Rules:

The code reviewer found at least three problems in the code.
Comments were mostly about design problems, not cosmetic issues.

No issues were found during code review.
Please confirm that you'll try to find at least three major problems while future reviews.

@carlosmiranda
Copy link
Contributor

@ypshenychka confirmed

@ypshenychka
Copy link

@carlosmiranda thanks

@ypshenychka
Copy link

@0crat quality bad

@0crat
Copy link
Collaborator

0crat commented Oct 11, 2018

Quality is low, no payment, see §31

@0crat
Copy link
Collaborator

0crat commented Oct 11, 2018

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants