-
Notifications
You must be signed in to change notification settings - Fork 11
For #18: Update qulice to version 0.17.4. #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Job #36 is now in scope, role is |
Job #36 is already in scope |
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
========================================
Coverage 92.1% 92.1%
Complexity 17 17
========================================
Files 3 3
Lines 38 38
Branches 1 1
========================================
Hits 35 35
Misses 3 3
Continue to review full report at Codecov.
|
This pull request #36 is assigned to @carlosmiranda/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale no comments, looks good to merge
@rultor merge |
@llorllale OK, I'll try to merge now. You can check the progress of the merge here |
@llorllale Done! FYI, the full log is here (took me 12min) |
Job #36 is not in the agenda of @carlosmiranda/z, can't retrieve data and time of add |
Job #36 is not in the agenda of @carlosmiranda/z, can't retrieve data and time of add |
Job #36 is not in the agenda of @carlosmiranda/z, can't inspect |
The job #36 is now out of scope |
@0crat status |
@ypshenychka This is what I know about this job in CAZUREFND, as in §32:
|
@carlosmiranda According to our QA Rules:
No issues were found during code review. |
@ypshenychka confirmed |
@carlosmiranda thanks |
@0crat quality bad |
Quality is low, no payment, see §31 |
Quality review completed: +8 point(s) just awarded to @ypshenychka/z |
For #18: Update qulice to version 0.17.4.