Remove warning messages at top/bottom of ordered select widget in fav…

…or of silently refusing to do silly things.
zopefoundation · Sep 19, 2015 · df27622 · df27622
1 parent f3b79c6
commit df27622
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -5,6 +5,10 @@ CHANGES
 3.2.7 (unreleased)
 ------------------
 
+- Remove "cannot move farther up/down" messages
+  in ordered select widget. 
+  [esteele]
+
 - Updated Traditional Chinese translation.
   [l34marr]
 

diff --git a/src/z3c/form/browser/orderedselect_input.js b/src/z3c/form/browser/orderedselect_input.js
@@ -65,9 +65,7 @@ function moveUp(name)
 
   if (toSel.selectedIndex == -1)
       selectionError();
-  else if (toSel.options[0].selected)
-      alert("Cannot move further up!");
-  else for (var i = 0; i < toSel.length; i++)
+  else for (var i = 1; i < toSel.length; i++)
     if (toSel.options[i].selected)
       {
       swapFields(toSel.options[i-1], toSel.options[i]);
@@ -83,10 +81,8 @@ function moveDown(name)
 
     if (toSel.selectedIndex == -1) {
         selectionError();
-    } else if (toSel.options[toSel.length-1].selected) {
-        alert("Cannot move further down!");
     } else {
-      for (var i = toSel.length-1; i >= 0; i--) {
+      for (var i = toSel.length-2; i >= 0; i--) {
         if (toSel.options[i].selected) {
           swapFields(toSel.options[i+1], toSel.options[i]);
         }